Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with css #3

Open
willianjusten opened this issue Jul 23, 2016 · 4 comments
Open

How to deal with css #3

willianjusten opened this issue Jul 23, 2016 · 4 comments
Labels

Comments

@willianjusten
Copy link
Contributor

willianjusten commented Jul 23, 2016

Should be normal with import by anothers?
Should be inline with Aphrodite/Radium/CssModules or anything else?

@willianjusten
Copy link
Contributor Author

@Nipher

@cauealvesbraz
Copy link

@willianjusten I really like the first option.

Because it's easy than others developers - that never wrote css inline via javascript - to adapt to the ecosystem with ease. It's more fluid.

Of course, given the choice, we must do some things related to tests...

I think a relevant discussion 👍

@jmpas
Copy link
Member

jmpas commented Jul 24, 2016

@willianjusten I think that it would be awesome to have a basic style when using these independents components on the application layer....
BUT it must be very easy to override it when wanted to, imo...

I don't know which is the best approach here, you mentioned some approaches that I don't know much about, I'll try to give a deeper look at this subject to have a stronger opinion

@willianjusten
Copy link
Contributor Author

willianjusten commented Aug 29, 2016

I was looking to the new Airbnb's project and they did a very nice way to handle with theming and css.
React Dates Theming.

Maybe we can use something similar... What you think @Nipher ?

krollopes pushed a commit to krollopes/lyef-react-component that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants