Replace gostats with tally #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarvar
reviewed
Jan 11, 2022
server/server.go
Outdated
| statsScope := stats.NewDefaultStore().Scope(userConfig.StatsNamespace) | ||
| statsScope.Store().AddStatGenerator(stats.NewRuntimeStats(statsScope.Scope("go"))) | ||
| // statsScope := stats.NewDefaultStore().Scope(userConfig.StatsNamespace) | ||
| // statsScope.Store().AddStatGenerator(stats.NewRuntimeStats(statsScope.Scope("go"))) |
server/metrics/statsd.go
Outdated
| tallystatsd "github.com/uber-go/tally/statsd" | ||
| ) | ||
|
|
||
| func NewLoggingScope(logger logging.SimpleLogging, statsNamespace string) (tally.Scope, io.Closer, error) { |
There was a problem hiding this comment.
This seems to only be used by tests? Can you leave a comment about it?
There was a problem hiding this comment.
It'll be used by the local server setup as well if it's running in debug mode.
msarvar
reviewed
Jan 11, 2022
server/metrics/statsd.go
Outdated
| } | ||
|
|
||
| func newReporter(cfg valid.Metrics, logger logging.SimpleLogging) (tally.StatsReporter, error) { | ||
| if cfg.Statsd == nil { |
There was a problem hiding this comment.
Is this always the case? What if there was a misconfigation that somehow set the statsd to nil? Shouldn't we return an error here? Looks like newLoggingReporter is only used by tests.
There was a problem hiding this comment.
the idea is here is to have a set of fields in that config object for statsd, prometheus and really any time of metrics supported by tally.
We are checking to see which metrics object is populated and if nothing is, we just return the logging scope.
Co-authored-by: Sarvar Muminov <43311+msarvar@users.noreply.github.com>
msarvar
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I create a
Metricsobject invalid.GlobalCfgwhich contains statsd info. This object should technically be parsed from yaml config and should eventually be used to support prometheus or any other metrics provider. (This will be done in a followup PR to not blow up the scope)I also added runtime stats publishing to our executor service. This means that when we OSS this change, we'll need to move executor service out from the lyft package.
This is the first PR to get this out of the door and ensure our stats are working as expected.