Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression introduced in approve policy command workflow. #82

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

nishkrishnan
Copy link
Contributor

@nishkrishnan nishkrishnan commented Jun 29, 2021

@msarvar
Copy link

msarvar commented Jun 29, 2021

@nishkrishnan there are bunch of tests that needs to be fixed in server/events/command_runner_test.go

Copy link

@msarvar msarvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it.

@nishkrishnan nishkrishnan merged commit ced49ec into release-v0.17.1-lyft.1 Jun 29, 2021
@nishkrishnan nishkrishnan deleted the nish/fix-approve-policies branch June 29, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants