-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI V2: header #696
UI V2: header #696
Conversation
hi @dschaller, mind giving this a first pass review? clutch/frontend/packages/core/src/AppLayout/tests/__snapshots__/layout.test.tsx.snap Line 3 in bfb56b4
|
b2fdd69
to
56842c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick pass, looking good
c7ae9c6
to
5927756
Compare
4b6c4a1
to
e4e4d5f
Compare
frontend/packages/core/src/AppLayout/stories/notifications.stories.tsx
Outdated
Show resolved
Hide resolved
Overall looks really good! A few more comments here and we should be good to go. Let's get this merged into the feature branch and open follow up PRs to drill into what the notification and user menus should look like with content populated. Feel free to punt on things like the hover and active states until then as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nits, lgtm otherwise
we will need a way to disable the notifications functionality via a prop since we don't support it yet, but we can follow up with that later.
@@ -68,20 +56,22 @@ const Header: React.FC = () => { | |||
|
|||
return ( | |||
<> | |||
<AppBar position="static" color="secondary"> | |||
<AppBar position="static" color="secondary" elevation={0}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has no effect with CSS overrides
<AppBar position="static" color="secondary" elevation={0}> | |
<AppBar position="static" elevation={0}> |
color: "#ffffff", | ||
opacity: "0.87", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make opacity part of the font color
color: "#ffffff", | |
opacity: "0.87", | |
color: "rgba(255, 255, 255, 0.87)", |
Description
This PR
Testing Performed
Created the components in storybook
Ran
make frontend-lint
andmake frontend-test
without errorsBefore
New (reflects latest commits)