Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui v2: restyle metadata table #729

Merged
merged 8 commits into from
Dec 4, 2020
Merged

ui v2: restyle metadata table #729

merged 8 commits into from
Dec 4, 2020

Conversation

dschaller
Copy link
Contributor

Description

Restyle metadata table.

Screen Shot 2020-12-01 at 8 49 59 PM

Testing Performed

storybook

@dschaller dschaller requested a review from a team as a code owner December 2, 2020 05:04
danielhochman
danielhochman reviewed Dec 3, 2020
View reviewed changes
Copy link
Collaborator

@danielhochman danielhochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

frontend/packages/core/src/Table/metadata-table.tsx Outdated Show resolved Hide resolved
frontend/packages/core/src/Table/metadata-table.tsx Outdated Show resolved Hide resolved
frontend/packages/core/src/Table/metadata-table.tsx Show resolved Hide resolved
frontend/packages/core/src/Table/stories/metadata-table.stories.tsx Show resolved Hide resolved
@dschaller dschaller merged commit c192ec7 into UIV2 Dec 4, 2020
@dschaller dschaller deleted the v2metadatatable branch December 4, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhochman danielhochman danielhochman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschaller @danielhochman