Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui v2: switches #763

Merged
merged 2 commits into from
Dec 15, 2020
Merged

ui v2: switches #763

merged 2 commits into from
Dec 15, 2020

Conversation

dschaller
Copy link
Contributor

Description

Add switches component.

Due to strothj/react-docgen-typescript-loader#113 the filename cannot be switch.

switch

Testing Performed

storybook

@dschaller dschaller requested a review from a team as a code owner December 8, 2020 22:12
export const Primary = Template.bind({});

export const Checked = Template.bind({});
Checked.props = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Checked.props = {
Checked.args = {

};

export const Disabled = Template.bind({});
Disabled.props = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Disabled.props = {
Disabled.args = {

const SwitchContainer = styled(MuiSwitch)({
".MuiSwitch-switchBase": {
":hover": {
backgroundColor: "rgba(231, 231, 234, .65)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
backgroundColor: "rgba(231, 231, 234, .65)",
backgroundColor: "rgba(13, 16, 48, 0.1)",

backgroundColor: "rgba(231, 231, 234, .65)",
},
":focus": {
backgroundColor: "rgba(226, 226, 230, .65)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
backgroundColor: "rgba(226, 226, 230, .65)",
backgroundColor: "rgba(13, 16, 48, 0.12)",

backgroundColor: "rgba(226, 226, 230, .65)",
},
":active": {
backgroundColor: "rgba(219, 219, 224, .65)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
backgroundColor: "rgba(219, 219, 224, .65)",
backgroundColor: "rgba(13, 16, 48, 0.15)",

},
".Mui-checked": {
":hover": {
backgroundColor: "rgba(245, 246, 253, .65)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
backgroundColor: "rgba(245, 246, 253, .65)",
backgroundColor: "rgba(53, 72, 212, 0.05)",

backgroundColor: "rgba(245, 246, 253, .65)",
},
":focus": {
backgroundColor: "rgba(235, 237, 251, .65)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
backgroundColor: "rgba(235, 237, 251, .65)",
backgroundColor: "rgba(53, 72, 212, 0.1)",

backgroundColor: "rgba(235, 237, 251, .65)",
},
":active": {
backgroundColor: "rgba(215, 218, 246, .65)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
backgroundColor: "rgba(215, 218, 246, .65)",
backgroundColor: "rgba(53, 72, 212, 0.2)",

Copy link
Collaborator

@danielhochman danielhochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than scarlett's suggestions

@dschaller dschaller merged commit 6f055fb into UIV2 Dec 15, 2020
@dschaller dschaller deleted the switches branch December 15, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants