ui v2: update UserInformation component #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarlettperry
changed the title
scarlettperry
force-pushed
the
sperry-update-avatar
branch
from
e1cdf3f to
f1176e2
Compare
scarlettperry
commented
Dec 14, 2020
| marginLeft: "12px", | ||
| padding: "0 6px", | ||
| marginLeft: "6px", | ||
| zIndex: 1101, |
There was a problem hiding this comment.
since this commit https://github.com/lyft/clutch/pull/760/files, the avatar popper has been hidden behind the appbar. so added the appbar zindex + 1
danielhochman
approved these changes
Dec 14, 2020
| </Grid> | ||
| ); | ||
| export const Primary = Template.bind({}); | ||
| Primary.args = { | ||
| data: [{ value: "Dashboard" }, { value: "Settings" }], | ||
| user: "fooBar@gmail.com", |
There was a problem hiding this comment.
super nit: use example domain
Suggested change
| user: "fooBar@gmail.com", | |
| user: "fooBar@example.com", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR:
Storybook
Testing Performed
Storybook, local app