Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui v2: button group #797

Merged
merged 2 commits into from
Dec 16, 2020
Merged

ui v2: button group #797

merged 2 commits into from
Dec 16, 2020

Conversation

dschaller
Copy link
Contributor

Description

Update button group to take Button as children instead of using a prop.

Testing Performed

Manual and storybook

@dschaller dschaller requested a review from a team as a code owner December 16, 2020 20:00
danielhochman
danielhochman approved these changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@danielhochman danielhochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending comment

@dschaller @danielhochman
Update frontend/packages/core/src/button.tsx
92ea921 
Co-authored-by: Daniel Hochman <danielhochman@users.noreply.github.com>
@dschaller dschaller merged commit 697bafd into UIV2 Dec 16, 2020
@dschaller dschaller deleted the buttonGroup branch December 16, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhochman danielhochman danielhochman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschaller @danielhochman