Use Go Modules #274
Use Go Modules #274
Conversation
danielmmetz
requested review from
anandswaminathan,
premsantosh and
maghamravi
as code owners
|
@danielmmetz wondering what's happening with integration tests. |
|
@danielmmetz Not sure how to validate this without - https://github.com/lyft/flinkk8soperator/blob/master/.github/workflows/actions.yml#L50 Want to reenable ? |
|
PTAL @leoluoInSea |
| go-version: 1.12 | ||
| - name: install | ||
| run: make install | ||
| go-version: "1.20" |
There was a problem hiding this comment.
is the double quote necessary?
There was a problem hiding this comment.
Yes—without it, YAML interprets this as "1.2" and you get a very old version of Go.
The integ tests are failing. I was trying to debug this and fix the issue, I was able to narrow down the problem is Flink app is stuck at deleting after every test till test time out. However I was unable to figure out why this happened and how to fix it yet. @anandswaminathan |
And while we're at it, upgrade to Go 1.20. In the process I had to change a lot of the dependencies. Some because the dependencies wouldn't resolve using Go modules, some because they were incompatible with others. The long and the short of it is: 1) the kubernetes dependency ecosystem is very rough and 2) this should be carefully validated during rollout given the number of dependency shifts.
Some other minor notes include some lint changes, or rewriting a very small bit of code to drop a dependency to have one less to fight with.