fix: race condition with pagination token #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 69.18% 69.37% +0.18%
==========================================
Files 383 383
Lines 6306 6299 -7
Branches 988 986 -2
==========================================
+ Hits 4363 4370 +7
+ Misses 1943 1929 -14
Continue to review full report at Codecov.
|
podehnal
approved these changes
Oct 16, 2020
20 tasks
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Oct 16, 2020
## [0.13.2](http://github.com/lyft/flyteconsole/compare/v0.13.1...v0.13.2) (2020-10-16) ### Bug Fixes * race condition with pagination token ([#105](http://github.com/lyft/flyteconsole/issues/105)) ([a5a9240](http://github.com/lyft/flyteconsole/commit/a5a92406567160dfb07238d30472786c15f34cb4))
|
🎉 This PR is included in version 0.13.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#546
usePaginationstores the pagination token in separate state hook. After theuseFetchableDatarefactor to use state machines, the fetchable will now reset before we have a change to update the token state, causing the value to persist across API calls. This updateusePaginationto store the token in the fetchable data, so that it is part of the context used by the state machine and will remain in sync with the data it applies to.Also removed the unnecessary use of a separate state hook for the
moreItemsAvailablefield, since that can be directly computed from the presence of thetoken.Since
usePaginationreturns an object that mostly looks like aFetchableData<T>, but using a different context shape under the hood, it was necessary to update the type forFetchableDataso that thestatefield was aFetchableState<any>. This changes feels okay, because the intended usage of passing that state field along is to allow consumers to check which state we are in for conditional rendering (usingstate.matches), not necessarily to allow logic based on the context contained within the state. I may open a follow-up PR to refactor the usage of fetch state to pass an even more restricted object, or remove the visibility of that state field from consuming code altogether.