fix: stop displaying empty descriptions #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olga Nad <olga@union.ai>
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
- Coverage 65.24% 65.23% -0.02%
==========================================
Files 391 391
Lines 8722 8724 +2
Branches 1507 1510 +3
==========================================
Hits 5691 5691
- Misses 3031 3033 +2
Continue to review full report at Codecov.
|
anrusina
reviewed
Mar 25, 2022
anrusina
previously approved these changes
Mar 25, 2022
Signed-off-by: Olga Nad <olga@union.ai>
|
lgtm |
flyte-bot
added a commit
that referenced
this pull request
Mar 28, 2022
## [0.47.2](http://github.com/lyft/flyteconsole/compare/v0.47.1...v0.47.2) (2022-03-28) ### Bug Fixes * stop displaying empty descriptions ([#346](http://github.com/lyft/flyteconsole/issues/346)) ([6a964f6](http://github.com/lyft/flyteconsole/commit/6a964f6ab4643d137477e072b9fed10e84a02af6))
|
🎉 This PR is included in version 0.47.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olga Nad olga@union.ai
Type
Are all requirements met?
Complete description
Workflow and task descriptions aren't properly populating due to issues on the backend, while they are being addressed, empty description string should not be rendered.
Demo
Workflows
Tasks