Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cached info to timeline #347

Merged
merged 6 commits into from
Mar 29, 2022
Merged

fix: add cached info to timeline #347

merged 6 commits into from
Mar 29, 2022

Conversation

anrusina
Copy link
Contributor

@anrusina anrusina commented Mar 28, 2022

This PR fixes next UI imperfections:

  • Added visual for Cached item
  • Tooltip position is always shows near to cursor position ( before it was always at the end of the bar, and as result was fully hidden in some cases)
  • Tooltip data - now includes formatted duration, status, and info id data was read from cache
  • Data label updates: duration formatting and add "From Cache" label
  • Updated chartBar structure to simplify future updates and allow Storybook rendering

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Storybook added
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Storybook item for few BarItems with controls

Screen Shot 2022-03-28 at 5 22 38 PM

- Storybook item for Single BarChart item with controls

Screen Shot 2022-03-28 at 5 23 05 PM

Video walk through:
https://user-images.githubusercontent.com/55718143/160510173-c104d31b-4f4b-4352-bad1-7d4356e01ee8.mp4

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/331

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #347 (a26b6cd) into master (6a964f6) will increase coverage by 0.11%.
The diff coverage is 67.94%.

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   65.22%   65.33%   +0.11%     
==========================================
  Files         391      394       +3     
  Lines        8725     8770      +45     
  Branches     1511     1518       +7     
==========================================
+ Hits         5691     5730      +39     
- Misses       3034     3040       +6     
Impacted Files Coverage Δ
...ts/Executions/ExecutionDetails/Timeline/helpers.ts 50.00% <ø> (ø)
...ns/ExecutionDetails/Timeline/BarChart/chartData.ts 17.50% <17.50%> (ø)
...s/ExecutionDetails/Timeline/BarChart/barOptions.ts 50.00% <50.00%> (ø)
...ecutions/ExecutionDetails/Timeline/chartHeader.tsx 76.92% <68.75%> (-4.90%) ⬇️
...ns/ExecutionDetails/Timeline/ExecutionTimeline.tsx 62.82% <77.77%> (+0.75%) ⬆️
...utions/ExecutionDetails/Timeline/BarChart/utils.ts 95.74% <95.74%> (ø)
...tions/ExecutionDetails/Timeline/BarChart/index.tsx 100.00% <100.00%> (ø)
...nts/Executions/ExecutionDetails/Timeline/index.tsx 96.87% <100.00%> (+0.32%) ⬆️
...cutions/ExecutionDetails/Timeline/scaleContext.tsx 78.04% <100.00%> (-0.22%) ⬇️
...components/Executions/NodeExecutionCacheStatus.tsx 91.30% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadafc8...a26b6cd. Read the comment docs.

Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
@anrusina anrusina changed the title [WIP] fix: add cached info to timeline fix: add cached info to timeline Mar 29, 2022
@anrusina anrusina requested review from a team, jsonporter and olga-union and removed request for a team March 29, 2022 01:12
Signed-off-by: Nastya Rusina <nastya@union.ai>
@anrusina anrusina marked this pull request as ready for review March 29, 2022 17:58
Signed-off-by: Nastya Rusina <nastya@union.ai>
Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.47.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Timeline] Cached items should have a visual representation in timeline
3 participants