Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: project domain default page #352

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

olga-union
Copy link
Contributor

@olga-union olga-union commented Apr 4, 2022

Signed-off-by: Olga Nad olga@union.ai

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Replaced Executions tab with Project Dashboard - extended ProjectExecutions with extra component and moved under ProjectDashboard.tsx, kept the route as /execution, because it's used for execution details. Added DomainSettingsSection component to display new information on the dashboard page.

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/317

Screenshots

Config available:
Screen Shot 2022-04-04 at 4 04 52 PM
Config not generated:
Screen Shot 2022-04-04 at 4 05 16 PM

UPD checked that list of executions is present and visible after these code changes in environment with data
Screen Shot 2022-04-05 at 1 30 07 PM

Signed-off-by: Olga Nad <olga@union.ai>
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #352 (6449a6c) into master (ce1f113) will increase coverage by 0.54%.
The diff coverage is 85.90%.

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   65.38%   65.92%   +0.54%     
==========================================
  Files         394      399       +5     
  Lines        8774     8849      +75     
  Branches     1519     1535      +16     
==========================================
+ Hits         5737     5834      +97     
+ Misses       3037     3015      -22     
Impacted Files Coverage Δ
...ExecutionDetails/ExecutionDetailsAppBarContent.tsx 88.57% <0.00%> (ø)
src/components/Navigation/ProjectNavigation.tsx 0.00% <0.00%> (ø)
src/components/Project/ProjectDetails.tsx 0.00% <0.00%> (ø)
src/components/common/styles.ts 100.00% <ø> (ø)
src/models/Common/constants.ts 90.90% <ø> (ø)
src/models/Project/utils.ts 25.00% <33.33%> (+25.00%) ⬆️
...tions/ExecutionDetails/NodeExecutionTabs/index.tsx 67.56% <67.56%> (ø)
...cutionDetails/NodeExecutionDetailsPanelContent.tsx 92.00% <76.92%> (+4.32%) ⬆️
...nDetails/NodeExecutionTabs/NodeExecutionInputs.tsx 75.00% <100.00%> (ø)
...Details/NodeExecutionTabs/NodeExecutionOutputs.tsx 75.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3c69b...6449a6c. Read the comment docs.

@anrusina anrusina requested review from a team, anrusina, jsonporter and ursucarina and removed request for a team April 4, 2022 21:43
Signed-off-by: Olga Nad <olga@union.ai>
@olga-union olga-union marked this pull request as ready for review April 5, 2022 21:28
Signed-off-by: Olga Nad <olga@union.ai>
Copy link
Contributor

@anrusina anrusina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.48.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Project-Domain default page
3 participants