fix: dimensionality per data type blob and be disabled in UI #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugene Jahn <eugenejahnjahn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 405 405
Lines 9056 9060 +4
Branches 1597 1600 +3
=======================================
+ Hits 6016 6019 +3
- Misses 3040 3041 +1
Continue to review full report at Codecov.
|
anrusina
approved these changes
Apr 12, 2022
flyte-bot
added a commit
that referenced
this pull request
Apr 12, 2022
## [0.51.1](http://github.com/lyft/flyteconsole/compare/v0.51.0...v0.51.1) (2022-04-12) ### Bug Fixes * dimensionality per data type blob and be disabled in UI ([#371](http://github.com/lyft/flyteconsole/issues/371)) ([dc38ae3](http://github.com/lyft/flyteconsole/commit/dc38ae39ceecce24f9a65f4c02f364d8ab05728d))
|
🎉 This PR is included in version 0.51.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eugene Jahn eugenejahnjahn@gmail.com
fix dimensionality per data type blob and be disabled in UI. For the blob input, we will set the dimensionality based on the blob type(if dimensionality from blob type is empty, we set to BlobDimensionality.SINGLE)
Type
Are all requirements met?
Complete description
add the dimensionality from typeDefinition?.literalType?.blob?.dimensionality
disable the select component
Tracking Issue
fixes https://github.com/flyteorg/flyteconsole/issues/336