tests: disable running tests in parallel in Travis CI #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis CI is slow and this makes tests that have timeouts flaky. We could increase the timeouts, but that would slow the feedback cycle of local development. Instead this commit disables running tests in parallel when the 'travis' build tag is provided (I had some spicier names for it, but I considering this is OSS 'travis' will do). Note: we do not rely on tests being parallel to identify race conditions - we do that explicitly and often.
haltwise
approved these changes
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis CI is slow and this makes tests that have timeouts flaky. We could increase the timeouts, but that would slow the feedback cycle of local development. Instead this commit disables running tests in parallel when the 'travis' build tag is provided (I had some spicier names for it, but I considering this is OSS 'travis' will do).
Note: we do not rely on tests being parallel to identify race conditions we do that explicitly and often.