Migrate to GHA #114
Merged
Migrate to GHA #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the Makefile. vet is replaced with `-vet=all`. We're not running quick anymore (no point in running the tests with the race detector disabled only to run it again with the race detector enabled). Finally, for linting, adopt golangci-lint.
This will help us keep GHA and go modules up to date.
Want to point the svg to the right branch too.
golfdish
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the Makefile. vet is replaced with
-vet=all. We're not runningquick anymore (no point in running the tests with the race detector disabled
only to run it again with the race detector enabled).
For linting, adopt golangci-lint, fixing all violations.
As a bonus, I'm also adding configuration for dependabot, so we can keep
dependencies up to date.