Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StartContext, remove Stop #147

Merged
merged 1 commit into from
Dec 20, 2022
Merged

add StartContext, remove Stop #147

merged 1 commit into from
Dec 20, 2022

Commits on Dec 20, 2022

  1. add StartContext, remove Stop

    This change removes the Stop() method from the previous change, and
    fixes the Start behavior to be backwards compatible.
    
    The previous change changed the behavior of Start() to be non-blocking
    from blocking. This is a change in API that we should revert. Stop is
    also removed - even though this too is a breaking change this is not a
    1.0 release and the release is short-lived as of right now.
    
    This change introduces a new method, StartContext, which should achieve
    the goals from the last change, but retain backwards compatibility.
    
    StartContext is a blocking call like Start is, but allows for a
    context to be passed in, thus allowing for cancellation.
    tomwans committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    0663279 View commit details
    Browse the repository at this point in the history