tcp_sink: don't hang on flush if reconnecting #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlievieth
force-pushed
the
cev/flush
branch
2 times, most recently
from
b55deff
to
cf95fa4
Compare
twoism
previously approved these changes
Mar 28, 2020
charlievieth
force-pushed
the
cev/flush
branch
2 times, most recently
from
c6af809
to
1b56639
Compare
This fixes a bug where the TCP Sink would hang indefinitely on Flush() if it was unable to reconnect. It also adds the SinkOption interface for configuring the TCP Sink, previously could only be done via environment variables (it still defaults to using env vars). This changes the function signature of NewTCPStatsdSink(), but the change should not be breaking since the new "opts" argument is variadic. This also significantly increases the code coverage of the TCP Sink tests.
|
Failing on go1.12 due to a subtle timing issue with the test. That I can't replicate locally. |
twoism
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the TCP Sink would hang indefinitely on Flush()
if it was unable to reconnect.
It also adds the SinkOption interface for configuring the TCP Sink,
previously could only be done via environment variables (it still
defaults to using env vars). This changes the function signature of
NewTCPStatsdSink(), but the change should not be breaking since the new
"opts" argument is variadic.
This also significantly increases the code coverage of the TCP Sink
tests.