This repository has been archived by the owner on May 17, 2024. It is now read-only.
Change NSArray and NSDictionary to use Swift literal dictionary and array #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github actions failed when try to select Xcode 10.2: Is there any problem if I change that to Xcode 11.1? |
|
So master has been updated Xcode wise. I'm still a bit worried about the performance implications here still 😞 but testing that part will definitely be a pain |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I'd like to contribute with this changes in
NSDictionaryandNSArrayto use Swift literal dictionary and array.@keith can you take a look at this, please?
Issue #80