Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up usage of deprecated protoc-gen-go/generator #79

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Jul 2, 2020

This package is deprecated and will be removed in the future, see https://github.com/golang/protobuf/blob/b5de78c91d0d09482d65f0a96927631cd343d7bb/protoc-gen-go/generator/generator.go#L42-L47.

This PR copies in the generator.CamelCase method, much the same as grpc-ecosystem/grpc-gateway#1260.

@mdehoog mdehoog force-pushed the generator-deprecated branch from 919e676 to 5a54f38 Compare July 2, 2020 05:07
@mdehoog
Copy link
Contributor Author

mdehoog commented Jul 30, 2020

@rodaine any thoughts or concerns with this change?

Copy link
Contributor

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, this looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants