allow devise < 4.7 #1269
Merged
allow devise < 4.7 #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doits
force-pushed
the
devise_4.6
branch
2 times, most recently
from
2235674 to
9cbee66
Compare
Closed
|
I hope you don't mind I updated the ruby versions in CI, fixed the sqlite3 issue Edit: Removed Rails 6 CI tests since there is more work to be done. Better to get this out faster without it. |
needed until rails/rails#35154 is released (only for newer versions then)
MaicolBen
reviewed
Mar 16, 2019
MaicolBen
reviewed
Mar 16, 2019
|
I think now it's ready with only the minimal changes needed. |
|
Can we get a patch version bump for this? |
|
@dkniffin @Polidoro I released v1.1.0 which includes some features and bug fixes (e.g. Mongo support), if you need it in v1.0.0 let me know and I can create a PR for that. If you were using master, you won't have any issue. You can see the differences in v1.0.0...master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests pass and my app works with it, too, but maybe someone with a more complicated setup could test it a little bit more.
Note: I had to explicitly
require 'devise/orm/active_record'inconfig/initializers/devise_token_auth.rbor else I had some errors about missing methoddevisein my models. Before I didn't had it and everything worked, but maybe now it is required? Not sure if this should be added tolib/generators/devise_token_auth/templates/devise_token_auth.rbhere, too.(Devise < 4.6 has a security issue, so I think it should be updated as fast as possible)