Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I made this work with chrome.storage.local #2

Open
ncri opened this issue Apr 6, 2015 · 2 comments
Open

I made this work with chrome.storage.local #2

ncri opened this issue Apr 6, 2015 · 2 comments

Comments

@ncri
Copy link

ncri commented Apr 6, 2015

I needed to, because I'm using j-toker in a packaged chrome app. So if anyone is interested I can create a fork.
@lynndylanhurley
Copy link
Owner

@ncri - send me a PR and I'll merge ASAP

@ncri
Copy link
Author

ncri commented Apr 7, 2015

It's not compatible with your original code. Because chrome.storage.local is asynchronous it was not straight forward to integrate. But it should be possible to add it as a third storage option. Not sure how complex the code will get though. I also dropped the multiple configurations to get my code working quickly.

mgmodell pushed a commit to mgmodell/j-toker that referenced this issue Apr 15, 2021
@RusinovAnton
Merge pull request lynndylanhurley#2 from RusinovAnton/remove-jquery
e43c07a 
Remove jquery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ncri @lynndylanhurley