Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

Rewrote lots of the code #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rewrote lots of the code #2

wants to merge 2 commits into from

Conversation

Deusdies
Copy link

@Deusdies Deusdies commented Feb 3, 2013

Rewrote a fair bit of code. WARNING: Redesigned the GUI in QtDesigner to follow the native Qt standards (does not use the PNGs).

Submiting the .ui file as well.

Reconnected the signals.

The program is now using a unified cross-platform main.py file instead of main_linux.py and main_windows.py.

Did not build the binary!

@lynnntropy
Copy link
Owner

I like what you've done with the code. I haven't really used Python much prior to this, and it shows.

Not too sure about the new UI, though. Not using the native UI/widgets was kind of the point of the redesign. Plus, I've never used QtDesigner, so it would be rather difficult to maintain.

@Deusdies
Copy link
Author

Deusdies commented Feb 3, 2013

You could make it so that the native widgets (the QPushButton, etc.) use the Holo style by CSS. Here's what I've come up with in a dozen or so minutes (this should also maintain uniform look across platforms):
linux_preview

Note that this is strictly CSS. The only thing missing from your mockup (as far as I can tell) is the checkbox style - that too can be made into holo-like, but that requires the images and the resource file, etc.

The orange background of the checkbox label should not be there, not sure what happened. Also, one of the buttons is darker because it reacts on the "hover" event.

@lynnntropy
Copy link
Owner

Wow, I really like it. I could definitely use something like that.

@Deusdies
Copy link
Author

Deusdies commented Feb 4, 2013

Committed that version 👍 Please test it under Windows. My guess is that you have to have Roboto fonts installed. I think there may be a way around that.

BTW, QtDesigner is very easy to use :)

@fearphage
Copy link

Is this pull request dead? Should it be updated/closed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants