[BugFix] fix the issue of LynxEngine reload process. #235
+34
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/land |
|
🛬 Landing process started! >>243.0 |
nhsprite
force-pushed
the
p/nihao.royal/fix-reload-issue
branch
from
cd3ecb5 to
e4b5ad8
Compare
|
/land |
|
🛬 Landing process started! >>244.0 |
|
🛬 Landing process started! >>245.0 |
LynxEngine does not support loadTemplate twice now, we need to make some clear logic to ensure loadTemplate twice is safe. At the same time, also make some renaming operation for better understanding of lynxTemplateRender: 1. createTemplateAssembler/destroyTemplateAssembler -> createLynxEngine/destroyLynxEngine; 2. this.prepareForRenderTemplate -> this.prepareLynxEngineIfNeeded; AutoSubmit: true issue: f-2937567
nhsprite
force-pushed
the
p/nihao.royal/fix-reload-issue
branch
from
e4b5ad8 to
474eef5
Compare
|
/land |
1 similar comment
|
/land |
|
🛬 Landing process started! >>247.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LynxEngine does not support loadTemplate twice now, we need to make some clear logic to ensure loadTemplate twice is safe.
AutoSubmit: true
issue: f-2937567
Summary
Checklist