-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis for Linux and add directives for macOS #26
Conversation
Signed-off-by: jdwelch <jdwelch@puppet.com>
[NB2: To trigger the release task(s), create a new GH Release from the fix-travis branch. Haven't tried doing this from the command line, yet.] |
Makefile
Outdated
@@ -120,20 +120,17 @@ vet: | |||
|
|||
PHONY+= dist-release | |||
dist-release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty brittle, obviously (e.g. will break if we go back to multiple binaries, etc.) but I went for explicit and simple for the time being. It's easy enough to change later as required.
https://github.com/lyraproj/lyra/releases/tag/fix-travis2 looks like this worked ok @jdwelch ? |
Yup, worked! |
+ adds back 'shrink' target + ensures `upx` is available on macOS target (for ↑ to work) Signed-off-by: jdwelch <jdwelch@puppet.com> ¯\_(ツ)_/¯ Signed-off-by: jdwelch <jdwelch@puppet.com> ¯\_(ツ)_/¯ Signed-off-by: jdwelch <jdwelch@puppet.com>
50d88ba
to
ce99131
Compare
Idk if this is the best way to do this, but it does seem to work, cf.
https://travis-ci.org/lyraproj/lyra/builds/466594959 and https://github.com/lyraproj/lyra/releases/tag/fix-travis
NB: I'm not sure why the previous
api_key
did not work; would be good to get someone else to see if the new one works for a user who is not me (ie the one who generated it)