Fix Travis for Linux and add directives for macOS #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2018 14:45
Signed-off-by: jdwelch <jdwelch@puppet.com>
|
[NB2: To trigger the release task(s), create a new GH Release from the fix-travis branch. Haven't tried doing this from the command line, yet.] |
jdwelch
commented
Dec 11, 2018
Makefile
Outdated
| @@ -120,20 +120,17 @@ vet: | |||
|
|
|||
| PHONY+= dist-release | |||
| dist-release: | |||
There was a problem hiding this comment.
This is pretty brittle, obviously (e.g. will break if we go back to multiple binaries, etc.) but I went for explicit and simple for the time being. It's easy enough to change later as required.
markfuller
approved these changes
Dec 12, 2018
https://github.com/lyraproj/lyra/releases/tag/fix-travis2 looks like this worked ok @jdwelch ? |
|
Yup, worked! |
+ adds back 'shrink' target + ensures `upx` is available on macOS target (for ↑ to work) Signed-off-by: jdwelch <jdwelch@puppet.com> ¯\_(ツ)_/¯ Signed-off-by: jdwelch <jdwelch@puppet.com> ¯\_(ツ)_/¯ Signed-off-by: jdwelch <jdwelch@puppet.com>
jdwelch
force-pushed
the
maint/fix-travis
branch
from
50d88ba
to
ce99131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idk if this is the best way to do this, but it does seem to work, cf.
https://travis-ci.org/lyraproj/lyra/builds/466594959 and https://github.com/lyraproj/lyra/releases/tag/fix-travis
NB: I'm not sure why the previous
api_keydid not work; would be good to get someone else to see if the new one works for a user who is not me (ie the one who generated it)