Fixed SonarQube issues; updated versions

lyricnz · May 21, 2017 · ccd415a · ccd415a
1 parent 7a48f71
commit ccd415a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -146,6 +146,7 @@ You are welcome to fix any tech debt that you see in SaaS dashboards:
 * [Codacy](https://www.codacy.com/app/brandonbyars/mountebank/dashboard)
 * [Bithound](https://www.bithound.io/github/bbyars/mountebank/master)
 * [Test Coverage](https://codeclimate.com/github/bbyars/mountebank/coverage)
+* [SonarQube](https://sonarqube.com/dashboard?id=mountebank)
 
 There are several linting tools run locally as well:
 

diff --git a/README.md b/README.md
@@ -88,7 +88,7 @@ you can contact me directly at brandon.byars@gmail.com.
 
 |                       |Node Version |Ubuntu 12.04                            |CentOS 6.7                            |OS X Mavericks                           |Windows Server 2012                          |
 |-----------------------|:-----------:|:--------------------------------------:|:------------------------------------:|:---------------------------------------:|:-------------------------------------------:|
-|npm                    | v7.8        |[![Build Status][travis-badge]][travis] | (not tested)                         | [![Build Status][travis-badge]][travis] | [![Build status][appveyor-badge]][appveyor] |
+|npm                    | v7.10       |[![Build Status][travis-badge]][travis] | (not tested)                         | [![Build Status][travis-badge]][travis] | [![Build status][appveyor-badge]][appveyor] |
 |npm                    | v6.10 (LTS) |[![Build Status][travis-badge]][travis] | (not tested)                         | [![Build Status][travis-badge]][travis] | [![Build status][appveyor-badge]][appveyor] |
 |npm                    | v4.4        |[![Build Status][travis-badge]][travis] | (not tested)                         | [![Build Status][travis-badge]][travis] | [![Build status][appveyor-badge]][appveyor] |
 |OS package             | v6.10       |[![Build Status][travis-badge]][travis] | (not tested                          | [![Build Status][travis-badge]][travis] | N/A                                         |

diff --git a/src/controllers/impostersController.js b/src/controllers/impostersController.js
@@ -183,7 +183,7 @@ function create (protocols, imposters, Imposter, logger) {
         var Q = require('q'),
             requestImposters = request.body.imposters || [],
             validationPromises = requestImposters.map(function (imposter) {
-                return validate(imposter, logger);
+                return validate(imposter);
             });
 
         logger.debug(requestDetails(request));

diff --git a/src/models/dryRunValidator.js b/src/models/dryRunValidator.js
@@ -69,12 +69,12 @@ function create (options) {
         }));
     }
 
-    function addDryRunErrors (stub, encoding, errors, logger, imposterState) {
+    function addDryRunErrors (stub, encoding, errors, logger) {
         var Q = require('q'),
             deferred = Q.defer();
 
         try {
-            dryRun(stub, encoding, logger, imposterState).done(deferred.resolve, function (reason) {
+            dryRun(stub, encoding, logger).done(deferred.resolve, function (reason) {
                 reason.source = reason.source || JSON.stringify(stub);
                 errors.push(reason);
                 deferred.resolve();
@@ -141,7 +141,7 @@ function create (options) {
         });
     }
 
-    function errorsForStub (stub, encoding, logger, imposterState) {
+    function errorsForStub (stub, encoding, logger) {
         var errors = [],
             Q = require('q'),
             util = require('util'),
@@ -163,7 +163,7 @@ function create (options) {
             deferred.resolve(errors);
         }
         else {
-            addDryRunErrors(stub, encoding, errors, logger, imposterState).done(function () {
+            addDryRunErrors(stub, encoding, errors, logger).done(function () {
                 deferred.resolve(errors);
             });
         }