添加构建测试

.github/workflows/build-test.yml

@@ -0,0 +1,28 @@
+name: Run build test
+
+on:
+  pull_request:
+    branches:
+      - dev
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out git repository
+        uses: actions/checkout@v4
+
+      - name: Install Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Eslint check
+        run: npm run lint
+
+      - name: Test Build
+        run: npm run build-test

package.json

@@ -13,6 +13,7 @@
     "rd": "react-devtools",
     "menu": "adb shell input keyevent 82",
     "bundle-android": "react-native bundle --platform android --dev true --entry-file index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res",
+    "build-test": "react-native bundle --platform android --dev true --entry-file index.js --bundle-output index.android.bundle --assets-dest res",
     "pack:android:debug": "./gradlew assembleDebug",
     "pack": "npm run pack:android",
     "pack:android": "cd android && gradlew.bat assembleRelease",

src/components/MetadataEditModal/MetadataForm.tsx

@@ -126,7 +126,7 @@ export default forwardRef<MetadataFormType, {}>((props, ref) => {
     }).finally(() => {
       matcheingPic.delete(path)
     })
-  }, [data.albumName, data.name, data.singer, t])
+  }, [data.albumName, data.interval, data.name, data.singer, isUnmounted, t])
   const handleOnlineMatchLyric = useCallback(() => {
     let path = filePath.current
     if (matcheingLrc.has(path)) return
@@ -164,7 +164,7 @@ export default forwardRef<MetadataFormType, {}>((props, ref) => {
     }).finally(() => {
       matcheingLrc.delete(path)
     })
-  }, [data.albumName, data.name, data.singer, t])
+  }, [data.albumName, data.interval, data.name, data.singer, isUnmounted, t])
   const handleUpdatePic = useCallback((path: string) => {
     setData(data => {
       return { ...data, pic: path }

src/components/common/ChoosePath/components/Header.tsx

@@ -42,7 +42,7 @@ export default memo(({
   }, [])
   useEffect(() => {
     checkExternalStoragePath()
-  }, [])
+  }, [checkExternalStoragePath])
 
   const refresh = () => {
     void onRefreshDir(path)

src/components/common/Popup.tsx

@@ -166,7 +166,7 @@ export default forwardRef<PopupType, PopupProps>(({
           },
         ] as const
     }
-  }, [position])
+  }, [position, statusBarHeight])
 
   return (
     <Modal onHide={onHide} keyHide={keyHide} bgHide={bgHide} bgColor="rgba(50,50,50,.2)" ref={modalRef}>

src/plugins/storage.ts

@@ -24,6 +24,8 @@ const buildData = (key: string, value: any, datas: Array<[string, string]>) => {
   datas.push([key, partKeyArrPrefix + JSON.stringify(partKeys)])
 }
 
+// 1.4.0 之前的数据分片存储方式，存在key的内容与分隔符冲突的问题
+// 1.4.0 开始改用数组存储，不再使用分隔符的方式
 const handleGetDataOld = async<T>(partKeys: string): Promise<T> => {
   const keys = partKeys.replace(partKeyPrefixRxp, '').split(keySplit)
 

src/screens/Home/Views/Mylist/MusicList/index.tsx

@@ -87,7 +87,7 @@ export default () => {
   const handleScrollToInfo = useCallback((info: LX.Music.MusicInfo) => {
     listRef.current?.scrollToInfo(info)
     handleExitSearch()
-  }, [])
+  }, [handleExitSearch])
   const onLayout = useCallback((e: LayoutChangeEvent) => {
     layoutHeightRef.current = e.nativeEvent.layout.height
   }, [])

src/screens/Home/index.tsx

@@ -23,7 +23,7 @@ export default ({ componentId }: Props) => {
     if (settingState.setting['player.startupPushPlayDetailScreen']) {
       navigations.pushPlayDetailScreen(componentId, true)
     }
-  }, [])
+  }, [componentId])
 
   return (
     <PageContent>

src/screens/PlayDetail/Horizontal/Lyric.tsx

@@ -101,7 +101,7 @@ export default () => {
   // }, [playMusicInfo])
 
   // const imgWidth = useMemo(() => layout.width * 0.75, [layout.width])
-  const handleScrollToActive = (index = lineRef.current.line) => {
+  const handleScrollToActive = useCallback((index = lineRef.current.line) => {
     if (index < 0) return
     if (flatListRef.current) {
       // console.log('handleScrollToActive', index)
@@ -130,7 +130,7 @@ export default () => {
         } catch {}
       }
     }
-  }
+  }, [line])
 
   const handleScroll = ({ nativeEvent }: NativeSyntheticEvent<NativeScrollEvent>) => {
     scrollInfoRef.current = nativeEvent
@@ -207,7 +207,7 @@ export default () => {
         }, 100)
       }
     })
-  }, [lyricLines])
+  }, [handleScrollToActive, lyricLines])
 
   useEffect(() => {
     if (line < 0) return
@@ -224,7 +224,7 @@ export default () => {
       delayScrollTimeout.current = null
       handleScrollToActive()
     }, 600)
-  }, [line])
+  }, [handleScrollToActive, line])
 
   useEffect(() => {
     requestAnimationFrame(() => {

src/screens/PlayDetail/Vertical/Lyric.tsx

@@ -141,7 +141,7 @@ export default () => {
   // }, [playMusicInfo])
 
   // const imgWidth = useMemo(() => layout.width * 0.75, [layout.width])
-  const handleScrollToActive = (index = lineRef.current.line) => {
+  const handleScrollToActive = useCallback((index = lineRef.current.line) => {
     if (index < 0) return
     if (flatListRef.current) {
       // console.log('handleScrollToActive', index)
@@ -170,7 +170,7 @@ export default () => {
         } catch {}
       }
     }
-  }
+  }, [line])
 
   const handleScroll = ({ nativeEvent }: NativeSyntheticEvent<NativeScrollEvent>) => {
     scrollInfoRef.current = nativeEvent
@@ -247,7 +247,7 @@ export default () => {
         }, 100)
       }
     })
-  }, [lyricLines])
+  }, [handleScrollToActive, lyricLines])
 
   useEffect(() => {
     if (line < 0) return
@@ -264,7 +264,7 @@ export default () => {
       delayScrollTimeout.current = null
       handleScrollToActive()
     }, 600)
-  }, [line])
+  }, [handleScrollToActive, line])
 
   useEffect(() => {
     requestAnimationFrame(() => {

src/screens/PlayDetail/Vertical/Pic.tsx

@@ -35,7 +35,7 @@ export default ({ componentId }: { componentId: string }) => {
       height: imgWidth,
       borderRadius: 2,
     }
-  }, [winHeight, winWidth])
+  }, [statusBarHeight, winHeight, winWidth])
 
   return (
     <View style={styles.container}>

src/screens/PlayDetail/components/PlayLine.tsx

@@ -61,7 +61,7 @@ export default forwardRef<PlayLineType, PlayLineProps>(({ onPlayLine }, ref) =>
       })
       // setVisible()
     },
-  }), [])
+  }))
 
   const handlePlayLine = () => {
     onPlayLine(time / 1000)

src/screens/SonglistDetail/MusicList.tsx

@@ -67,7 +67,7 @@ export default forwardRef<MusicListType, MusicListProps>(({ componentId }, ref)
         })
       }
     },
-  }), [])
+  }))
 
   useEffect(() => {
     isUnmountedRef.current = false

src/utils/hooks/useAnimateColor.ts

@@ -5,6 +5,7 @@ import { Animated } from 'react-native'
 const ANIMATION_DURATION = 800
 
 export const useAnimateColor = (color: string) => {
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   const anim = useMemo(() => new Animated.Value(0), [color])
   const [finished, setFinished] = useState(true)
   const currentColor = useRef(color)
@@ -29,6 +30,7 @@ export const useAnimateColor = (color: string) => {
     requestAnimationFrame(() => {
       currentColor.current = nextColor
     })
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [nextColor])
 
   return [animColor, finished] as const

src/utils/hooks/useAnimateNumber.ts

@@ -5,6 +5,7 @@ import { Animated } from 'react-native'
 export const DEFAULT_DURATION = 800
 
 export const useAnimateNumber = (val: number, duration = DEFAULT_DURATION, useNativeDriver = true) => {
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   const anim = useMemo(() => new Animated.Value(0), [val])
   const [finished, setFinished] = useState(true)
   const currentNumber = useRef(val)
@@ -29,6 +30,7 @@ export const useAnimateNumber = (val: number, duration = DEFAULT_DURATION, useNa
     requestAnimationFrame(() => {
       currentNumber.current = nextNumber
     })
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [nextNumber])
 
   return [animNumber, finished] as const
@@ -54,6 +56,7 @@ export const useAnimateOnecNumber = (val: number, toVal: number, duration = DEFA
       // currentNumber.current = nextNumber
       setFinished(true)
     })
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [])
 
   return [animNumber, finished] as const