Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Nightly required #8

Closed
dandxy89 opened this issue Jun 20, 2024 · 4 comments
Closed

Is Nightly required #8

dandxy89 opened this issue Jun 20, 2024 · 4 comments
Assignees

Comments

@dandxy89
Copy link

Hello @lytefast

Would it be possible to create a non-nightly variant of this crate?

#![feature(div_duration)]
#![feature(is_some_and)]

From src/lib.rs

@lytefast
Copy link
Owner

lytefast commented Jun 25, 2024

No it's not. This is mainly a code readability thing. We can just as easily patch these out. However these features are both stabilized and I'm hoping to just wait for the next release.

https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some_and as of 1.70.0

rust-lang/rust#63139 - I'm inclined to wait as it looks like it's going to be stabilized soon from comments on all the threads

edit: looks like this is 1.80 https://github.com/rust-lang/rust/blob/master/library/core/src/time.rs#L1115C49-L1115C55

@lytefast lytefast self-assigned this Jul 2, 2024
@lytefast
Copy link
Owner

lytefast commented Jul 2, 2024

@dandxy89 Looks like 1.80 is going to stabilizediv_duration on July 25. I'll merge when it hits stable.

@dandxy89
Copy link
Author

dandxy89 commented Jul 2, 2024

Wow. That's great timing. Appreciate your flexibility.

lytefast added a commit that referenced this issue Aug 1, 2024
- bump the version to `0.6.0` since we now require min rust version.
- 1.80 is, as of now [still in beta](https://releases.rs/docs/1.80.0/) and is planned to be stable 25 July, 2024

#8 (comment)
@lytefast
Copy link
Owner

lytefast commented Aug 1, 2024

pushed v0.6.0 with the changes as well.

@lytefast lytefast closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants