Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Code Causes Prompt to Blow Up #15

Closed
jkrot opened this issue Jul 8, 2016 · 8 comments
Closed

New Code Causes Prompt to Blow Up #15

jkrot opened this issue Jul 8, 2016 · 8 comments

Comments

@jkrot
Copy link

jkrot commented Jul 8, 2016

I am running this on a mac and using the new code my prompt looks like, going back a commit and it looks fine.
screen shot 2016-07-08 at 3 49 48 pm

@dmccaffery
Copy link

Seconded. Definitely an issue on OS X currently.

@lyze
Copy link
Owner

lyze commented Jul 10, 2016

I won't have access to a Mac until tomorrow, so I can't debug the issue yet. In the meantime, what does the output look like if ANSI color interpretation is disabled in the terminal settings? I'm guessing this happens on the (old 3.x) bash that ships with OSX by default?

@dmccaffery
Copy link

GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin16)
Copyright (C) 2007 Free Software Foundation, Inc.

Thats the version of bash that I am using. It is quite old. I'll have to reinstall the latest bits and disable ANSI to get back to you re: what the output looks like without ANSI.

@dmccaffery
Copy link

Before (ANSI):
screen shot 2016-07-11 at 5 19 49 am
After (ANSI):
screen shot 2016-07-11 at 5 25 16 am

ANSI disabled:
screen shot 2016-07-11 at 5 26 31 am

Does not emit the ANSI color codes when disabling ANSI... OS X terminal just swallows them, it would appear. I tried changing the TERM as well to no effect.

The prompt is set using the following script (part of my prompt kit):
https://github.com/pulsebridge/uber/blob/master/src/scripts/set-prompt.sh

lyze added a commit that referenced this issue Jul 11, 2016
Works for bash/zsh, did not test on OSX bash.
@lyze
Copy link
Owner

lyze commented Jul 11, 2016

I think 8d28204 should fix things. I promise I do know how to get a backslash to show up with echo... 😿 I can check for sure later when I get to a Mac.

@dmccaffery
Copy link

@lyze confirmed -- 8d28204 works for me. :shipit:

@dmccaffery
Copy link

Proof:
screen shot 2016-07-11 at 7 16 48 am

@lyze
Copy link
Owner

lyze commented Jul 12, 2016

Works for me too! Closing.

@lyze lyze closed this as completed Jul 12, 2016
dmccaffery pushed a commit to automotiveMastermind/prompt that referenced this issue Jul 14, 2016
Workaround for lyze/posh-git-sh#15 is no longer necessary. Removing.

#5
dmccaffery pushed a commit to automotiveMastermind/prompt that referenced this issue Aug 19, 2016
Workaround for lyze/posh-git-sh#15 is no longer necessary. Removing.

#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants