Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have decided that git-submodules is probably not the right solution for us. The main disadvantage I found (after trying to write the documentation) is that it changes the workflow of everyone, requiring users to add extra flags or run additional commands. If someone forgets these extra flags, it has the potential to screw things up for everyone.
Instead, I propose we use git-subtree. The advantages of this approach are:
Updating Elemental with git-subtree is relatively simple.
$ git subtree pull --prefix=src/elemental --squash https://github.com/elemental/Elemental.git
$ git commit -a -m "Updated Elemental to "
$ git push
where is a branch, tag, or SHA. User only need to "git pull" to get the changes.
If we want to modify files in elemental, then we can do so as if they were any other file in MADNESS.