fix: fixes 1445 and implementing correct interface types

For all the connector class definitions the implementation are fixed to follow their interface definition and to match in consistent way for all the connectors Closes: hyperledger-cacti#1445 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin · Oct 25, 2021 · eefa228 · eefa228
1 parent 305171b
commit eefa228
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...s/cactus-plugin-ledger-connector-besu/src/main/typescript/plugin-ledger-connector-besu.ts b/...s/cactus-plugin-ledger-connector-besu/src/main/typescript/plugin-ledger-connector-besu.ts
@@ -56,7 +56,6 @@ import {
   WatchBlocksV1,
   ConsistencyStrategy,
   DeployContractSolidityBytecodeV1Request,
-  DeployContractSolidityBytecodeV1Response,
   EthContractInvocationType,
   InvokeContractV1Request,
   InvokeContractV1Response,
@@ -108,7 +107,7 @@ export class PluginLedgerConnectorBesu
   implements
     IPluginLedgerConnector<
       DeployContractSolidityBytecodeV1Request,
-      DeployContractSolidityBytecodeV1Response,
+      RunTransactionResponse,
       RunTransactionRequest,
       RunTransactionResponse
     >,

diff --git a/...s/cactus-plugin-ledger-connector-xdai/src/main/typescript/plugin-ledger-connector-xdai.ts b/...s/cactus-plugin-ledger-connector-xdai/src/main/typescript/plugin-ledger-connector-xdai.ts
@@ -33,7 +33,6 @@ import { DeployContractSolidityBytecodeEndpoint } from "./web-services/deploy-co
 import {
   ConsistencyStrategy,
   DeployContractV1Request,
-  DeployContractV1Response,
   EthContractInvocationType,
   InvokeContractV1Request,
   InvokeContractV1Response,
@@ -68,7 +67,7 @@ export class PluginLedgerConnectorXdai
   implements
     IPluginLedgerConnector<
       DeployContractV1Request,
-      DeployContractV1Response,
+      RunTransactionV1Response,
       RunTransactionV1Request,
       RunTransactionV1Response
     >,