Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error string label to bbr enabled metric #373

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Aug 24, 2022

We have learned that in practice, we see many status=false due to "bad file descriptor" errors. Unfortunately, this is not the error case we were originally interested in for the ndt7_measurer_bbr_enabled_total.

To be able to identify failures enabling BBR due to the module not being present, this change adds the error string to the metric labels. We are looking for the error "no such file or directory".


This change is Reviewable

@stephen-soltesz
Copy link
Contributor Author

FYI: @nkinkade

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1609

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 81.658%

Files with Coverage Reduction New Missed Lines %
ndt5/c2s/c2s.go 1 74.11%
ndt7/upload/sender/sender.go 5 65.91%
Totals Coverage Status
Change from base Build 1607: 0.07%
Covered Lines: 1803
Relevant Lines: 2208

💛 - Coveralls

@stephen-soltesz stephen-soltesz merged commit aae1d90 into main Aug 24, 2022
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-bbr-enable branch August 24, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants