Add error string label to bbr enabled metric #373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have learned that in practice, we see many
status=false
due to "bad file descriptor" errors. Unfortunately, this is not the error case we were originally interested in for thendt7_measurer_bbr_enabled_total
.To be able to identify failures enabling BBR due to the module not being present, this change adds the error string to the metric labels. We are looking for the error
"no such file or directory"
.This change is