Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ndt7-protocol): clarify ElapsedTime semantics #381

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Feb 17, 2023

This change is Reviewable

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: with a comment.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @bassosimone)


spec/ndt7-protocol.md line 350 at r1 (raw file):

information at different times. Usually the times would be very close in
time but there could be tiny differences caused by collecting distinct
metrics from distinct threads (or goroutines).

I would not reference goroutines here as they are specific to Go.

@bassosimone
Copy link
Contributor Author

@robertodauria done, thank you!

@robertodauria robertodauria merged commit a171944 into m-lab:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants