Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to Linux 4.19 #382

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

nosnilmot
Copy link
Contributor

@nosnilmot nosnilmot commented Mar 1, 2023

The NDT7 protocol mentions M-Lab uses Linux 4.19. Certain key TCP_INFO struct members are only available in Linux 4.19+ (notably bytes_sent), so for consistency update the README.md to say the same.

btw, the NDT7 protocol also says:

An implementation running on
a kernel where a specific TCP_INFO variable mentioned in this specification
is missing SHOULD NOT include such variable in the TCPInfo object sent to
the client.

but that is not what this implementation does, it sends a full TCPInfo object where missing variables have 0 value.


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1642

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.463%

Totals Coverage Status
Change from base Build 1641: 0.0%
Covered Lines: 1815
Relevant Lines: 2228

💛 - Coveralls

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: - thanks!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@robertodauria robertodauria merged commit cdcfe8b into m-lab:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants