Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and add example configuration #32

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Mar 8, 2021

This change provides a major update to the bqx README.md documentation and adds an example configuration for k8s and a sample query. The README walks through the provided example. The README does a better job of describing the expected column format for values and how metric names are derived.


This change is Reviewable

@stephen-soltesz stephen-soltesz requested a review from nkinkade March 8, 2021 18:37
@coveralls
Copy link
Collaborator

coveralls commented Mar 8, 2021

Pull Request Test Coverage Report for Build 105

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 101: 0.0%
Covered Lines: 260
Relevant Lines: 260

💛 - Coveralls

Copy link

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: 0 of 1 LGTMs obtained


README.md, line 31 at r1 (raw file):

The bigquery-exporter identifies value columns by looking for column names
that match the pattern: `value([.+])`. All characters in the matching group
`([.+])` are appending to the metric prefix taken from the query file name.

s/appending/appended/

@stephen-soltesz stephen-soltesz merged commit 587e6f8 into main Mar 8, 2021
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-more-docs2 branch August 12, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants