Add txcontroller max-rate rules for 40Gbps uplinks #349
Conversation
The new Ziply sites have 40Gbps uplinks.
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @nkinkade)
lib/site.jsonnet line 204 at r1 (raw file):
if subnet == 26 then // 10Gbits/s 10000000000
Can you say more about this branch? There's something I'm missing.
Is Zipply running a standard configuration site (e.g. /26) with 40G switches? Why would we not want this condition to be 30Gbps?
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @stephen-soltesz)
lib/site.jsonnet line 204 at r1 (raw file):
Previously, stephen-soltesz (Stephen Soltesz) wrote…
Can you say more about this branch? There's something I'm missing.
Is Zipply running a standard configuration site (e.g. /26) with 40G switches? Why would we not want this condition to be 30Gbps?
@stephen-soltesz : This is just following our "standard" convention of setting the max-rate for the tx-controller to 1/4 of the uplink speed for "full" sites, and 3/4 of the uplink speed for "minimal" sites.
Yeah, Ziply is deploying full sites, with 4 Dell R630 servers (connected to the switch at 40Gbps), and 1 Juniper QFX switch (with a 40Gbps) uplink to Ziply's network.
Did I do my math wrong, or so we need another strategy for this type of site?
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @nkinkade)
lib/site.jsonnet line 204 at r1 (raw file):
Previously, nkinkade wrote…
@stephen-soltesz : This is just following our "standard" convention of setting the max-rate for the tx-controller to 1/4 of the uplink speed for "full" sites, and 3/4 of the uplink speed for "minimal" sites.
Yeah, Ziply is deploying full sites, with 4 Dell R630 servers (connected to the switch at 40Gbps), and 1 Juniper QFX switch (with a 40Gbps) uplink to Ziply's network.
Did I do my math wrong, or so we need another strategy for this type of site?
No this is right. For some reason, my brain didn't go to the 3xNode capacity - lgtm
The new Ziply sites have 40Gbps uplinks. This sets the max-rates to 10Gbps for regular "full" sites, and 30Gbps for "minimal" sites.
This change is