Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Prometheus metrics to pass the prometheus linter #106

Open
pboothe opened this issue Oct 17, 2019 · 0 comments
Open

Update the Prometheus metrics to pass the prometheus linter #106

pboothe opened this issue Oct 17, 2019 · 0 comments
Labels
backlog P3 sre/review

Comments

@pboothe
Copy link
Contributor

pboothe commented Oct 17, 2019

Output on travis:

605    promtest.go:42: Bad metric tcpinfo_cache_count_histogram: metric name should not include type 'histogram'
606    promtest.go:42: Bad metric tcpinfo_connection_count_histogram: metric name should not include type 'histogram'
607    promtest.go:42: Bad metric tcpinfo_polling_interval_histogram: metric name should not include type 'histogram'
608    promtest.go:42: Bad metric tcpinfo_receive_rate_histogram: metric name should not include type 'histogram'
609    promtest.go:42: Bad metric tcpinfo_send_rate_histogram: metric name should not include type 'histogram'
610    promtest.go:42: Bad metric tcpinfo_syscall_time_histogram: metric name should not include type 'histogram'
pboothe added a commit that referenced this issue Oct 17, 2019
@pboothe
Metrics no longer pass the prometheus linter.
ddae0fb 
Filed #106
pboothe added a commit that referenced this issue Oct 18, 2019
@pboothe
Adds the Unix domain server for TCP events. (#105)
ebe46a0 
* Adds the Unix domain server for TCP events.

To do: integrate server into existing tcp-info codebase.
Also updates the travis file to remove an outdated flag.

* Metrics no longer pass the prometheus linter.
Filed #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog P3 sre/review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pboothe @stephen-soltesz