hdf5: Warn when attaching metadata to absent key

Signed-off-by: yuk <yuk@m-labs.hk>
m-labs · Oct 18, 2022 · 3767779 · 3767779
1 parent 22e6db8
commit 3767779
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/artiq/examples/no_hardware/repository/hdf5_attributes.py b/artiq/examples/no_hardware/repository/hdf5_attributes.py
@@ -19,3 +19,6 @@ def run(self):
         self.set_dataset("dummy", dummy,
                          broadcast=True, archive=True)
         self.set_dataset_metadata("dummy", {"k1": "v1", "k2": "v2"})
+
+        # Attach metadata to an absent key is no-op
+        self.set_dataset_metadata("nothing", {"no": "op"})
diff --git a/artiq/master/worker_db.py b/artiq/master/worker_db.py
@@ -166,6 +166,8 @@ def get(self, key, archive=False):
 
     def set_metadata(self, key, metadata):
         if key:
+            if key not in self.local:
+                logger.warning(f"Key '{key}' not found in dataset.")
             self.hdf5_attributes["datasets/" + key] = metadata
         else:
             self.hdf5_attributes["datasets"] = metadata