Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: clean up devShells #2632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bloxx12
Copy link
Contributor

@bloxx12 bloxx12 commented Dec 1, 2024

Move both devShells into devshells.<...>,
packages should be used in shells, as the logical difference between nativeBuildInputs and buildInputs no longer applies.

can't really test since I don't have vivado installed, it should just work however.

ARTIQ Pull Request

Description of Changes

Related Issue

Type of Changes

Type
🔨 Refactoring

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

  • Use correct spelling and grammar.
  • Update RELEASE_NOTES.rst if there are noteworthy changes, especially if there are changes to existing APIs.
  • Close/update issues.
  • Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).

Code Changes

  • Test your changes or have someone test them. Mention what was tested and how.

Move both devShells into devshells.<...>,
switch from buildInputs to packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant