Skip to content

fix(app): fixes the re-enter input validation crashing the application#132

Open
turingAlan wants to merge 4 commits intom2b3:mainfrom
turingAlan:fix/authentication
Open

fix(app): fixes the re-enter input validation crashing the application#132
turingAlan wants to merge 4 commits intom2b3:mainfrom
turingAlan:fix/authentication

Conversation

@turingAlan
Copy link
Contributor

@turingAlan turingAlan commented Mar 22, 2025

Fixes Re-Enter Input Validation Crash, Package Versioning, TypeScript Errors, and CI Issues

Description

This pull request addresses a critical issue where the application was crashing due to a faulty regex pattern used in the re-enter form input validation. The problematic regex has been replaced with a more robust validation function to ensure stability and prevent crashes. Additionally, this PR includes updates to the yoopta-editor package and its plugins, making their versioning consistent to resolve TypeScript errors caused by mismatched versions and typedef issues. Lastly, a TypeScript error related to NodeJS.Timeout has been fixed to improve type safety and compatibility. Finally, this PR includes updates to address CI pipeline issues.
Note: All these fixes are bundled into this single PR, so all the test cases and CI for this pull request should be good to go now!

Changes Made:

  1. Re-Enter Input Validation Fix:

    • Removed the crashing regex pattern in the re-enter form input.
    • Implemented a new validation function to handle input validation more reliably.
  2. Consistent Package Versioning:

    • Updated the versioning of yoopta-editor and its plugins to a consistent 4.6.6 to eliminate TypeScript errors caused by mismatched versions and typedef inconsistencies.
  3. TypeScript Fix:

    • Resolved a TypeScript error related to NodeJS.Timeout by ensuring proper type definitions and compatibility.
  4. CI Pipeline Improvements:

    • Addressed issues in the CI configuration regarding node engine version mismatch.

Screenhots (if any):
Screenshot From 2025-03-23 00-34-55

new Regex in pattern of re-enter forminput casuing the application to crash replaced the pattern with validation function instead
fixes the test cases not running because of some jest dependency issues
@turingAlan
Copy link
Contributor Author

@armanalam03 @dinakar17, could you review this PR? It resolves a critical bug causing the app to crash on re-enter password validation with any special character, especially common with built-in password managers. Thanks!

@dinakar17
Copy link
Contributor

That looks good. I'll merge it by EOD

@turingAlan
Copy link
Contributor Author

Awesome, thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants