fix(app): fixes the re-enter input validation crashing the application#132
Open
turingAlan wants to merge 4 commits intom2b3:mainfrom
Open
fix(app): fixes the re-enter input validation crashing the application#132turingAlan wants to merge 4 commits intom2b3:mainfrom
turingAlan wants to merge 4 commits intom2b3:mainfrom
Conversation
new Regex in pattern of re-enter forminput casuing the application to crash replaced the pattern with validation function instead
fixes the test cases not running because of some jest dependency issues
Contributor
Author
|
@armanalam03 @dinakar17, could you review this PR? It resolves a critical bug causing the app to crash on re-enter password validation with any special character, especially common with built-in password managers. Thanks! |
Contributor
|
That looks good. I'll merge it by EOD |
Contributor
Author
|
Awesome, thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Re-Enter Input Validation Crash, Package Versioning, TypeScript Errors, and CI Issues
Description
This pull request addresses a critical issue where the application was crashing due to a faulty regex pattern used in the re-enter form input validation. The problematic regex has been replaced with a more robust validation function to ensure stability and prevent crashes. Additionally, this PR includes updates to the
yoopta-editorpackage and its plugins, making their versioning consistent to resolve TypeScript errors caused by mismatched versions and typedef issues. Lastly, a TypeScript error related toNodeJS.Timeouthas been fixed to improve type safety and compatibility. Finally, this PR includes updates to address CI pipeline issues.Note: All these fixes are bundled into this single PR, so all the test cases and CI for this pull request should be good to go now!
Changes Made:
Re-Enter Input Validation Fix:
Consistent Package Versioning:
yoopta-editorand its plugins to a consistent4.6.6to eliminate TypeScript errors caused by mismatched versions and typedef inconsistencies.TypeScript Fix:
CI Pipeline Improvements:
Screenhots (if any):
