Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pr-preview workflow #109

Closed

Conversation

IamShubhamGupto
Copy link
Member

@IamShubhamGupto IamShubhamGupto commented May 4, 2023

  • new workflow for pr-previews
  • deploy action will now run only when there is a push to the main branch
  • preview action will now run on any pull request

@IamShubhamGupto
Copy link
Member Author

I forget

We need to give GitHub-actions permissions to comment on our repositories. To make the action succeed, we need to enable settings->actions->general -> allow read and write

Screenshot 2023-05-03 at 9 29 34 PM

on enabling this permission and rerunning the above action, we should see a pr-preview (unless I have forgotten any other settings ive updated in my repo)

@dhruvbalwada
Copy link
Collaborator

The allow read and write option is selected. Should I merge when the checks are done?

@IamShubhamGupto
Copy link
Member Author

@dhruvbalwada
Yes, ive retriggered the workflow again, it should pass now and comment a preview website link.

If not, ill work on this tonight and get back to you

@IamShubhamGupto
Copy link
Member Author

the logs of this action

  env:
    INPUT_RUN_POST: true
    CONDA_PKGS_DIR: /home/runner/conda_pkgs_dir
    action: deploy
    targetdir: pr-preview/pr-109
    pr: 109
    pagesurl: m2lines.github.io/L96_demo
    emptydir: /tmp/tmp.W01OqvvlCR
    datetime: 2023-05-04 14:55 UTC
    actionref: v1
    actionrepo: rossjrw/pr-preview-action
    deployrepo: m2lines/L96_demo
    token: ***
    action_version: b41d0b1cd2d48a2a2c2c6528ff2ce9cc8951ecd1
    deployment_status: success
Error: Resource not accessible by integration

Some permission is still missing and is required by GitHub actions. Ill get back to you soon on this

@dhruvbalwada
Copy link
Collaborator

We closing this, since it was adapted and deployed through #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants