Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix climatology figure #122

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Conversation

NoraLoose
Copy link
Member

I believe there is a small bug in the gcm-parameterization-problem.ipynb notebook. The figure that shows the climatologies of X_true vs. X_gcm vs. X_gcm_no_param plots the wrong line for X_true, namely

plt.plot(dist[-1], linewidth=3, color="k", label="Truth")

This PR changes the line to

plt.plot(np.mean(X_true, 0), linewidth=3, color="k", label="Truth")

I think I installed pre-commit only after making my commits, so I hope things are not too messy. I can roll back my commits, and re-commit if necessary.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@NoraLoose
Copy link
Member Author

Ok nice, pre-commit ci fixed it for us.

@LaureZanna LaureZanna merged commit 9b7262f into m2lines:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants