Updated Review for 04Subgrid-parametrization-pytorch #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradient_decent.ipynb and Neural_network_for_Lorenz96.ipynb: 1. Changed order of weights from w1, w0 to w0, w1. 2. Fixed typos, changed markdowns so that the style is consistent.
gradient_decent.ipynb and Neural_network_for_Lorenz96.ipynb: 1. Changed order of weights from w1, w0 to w0, w1. 2. Fixed typos, changed markdowns so that the style is consistent.
gradient_decent.ipynb and Neural_network_for_Lorenz96.ipynb: 1. Changed order of weights from w1, w0 to w0, w1 in gradient_decent.ipynb 2. Fixed some small bugs related to path 3. Defined a new nn_3l_decay object so that the training with L2 norm does not apply to a previous NN object 4. Fixed typos, changed markdowns so that the style is consistent.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
yaniyuval
reviewed
May 17, 2022
| @@ -11,46 +11,32 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Here is the issue @yaniyuval and @adcroft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #18. I could not push to that branch because it looks like @dante831's fork has been deleted (https://github.com/dante831/L96_demo).