Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code page and thumbnail fix #56

Merged
merged 2 commits into from
Sep 5, 2023
Merged

code page and thumbnail fix #56

merged 2 commits into from
Sep 5, 2023

Conversation

IamShubhamGupto
Copy link
Member

@IamShubhamGupto IamShubhamGupto commented Sep 5, 2023

Screenshot 2023-09-04 at 8 05 24 PM

@NoraLoose
Copy link
Member

Thanks for this PR @IamShubhamGupto - awesome progress!

IMO it would look more organized if we could somehow keep the structure that I suggested in #55. I.e., sections like "Machine learning tutorials and tools" and then have the associated items in that section.

Also, where does the link take you when you for example click on "Differentiable QG Model"? I think it could be nice to have several links per item, as I suggested in #55. For example, "Differentiable QG Model" could have a link to the actual code, and another one to the paper.

@IamShubhamGupto
Copy link
Member Author

Thanks for this PR @IamShubhamGupto - awesome progress!

IMO it would look more organized if we could somehow keep the structure that I suggested in #55. I.e., sections like "Machine learning tutorials and tools" and then have the associated items in that section.

Also, where does the link take you when you for example click on "Differentiable QG Model"? I think it could be nice to have several links per item, as I suggested in #55. For example, "Differentiable QG Model" could have a link to the actual code, and another one to the paper.

Could you finalize the other in which I should display the content, I feel dataset and tutorial have less content so they should come below

as for the links, the titles point to the paper itself. The tags website code and dataset used point to those individual links respectively.

@IamShubhamGupto
Copy link
Member Author

IamShubhamGupto commented Sep 5, 2023

@NoraLoose

I was able to add divisions to the code, the results

Screenshot 2023-09-04 at 9 58 46 PM Screenshot 2023-09-04 at 9 58 54 PM

Let me know if I should push these

Update

Fixed the font in ocean parameterization
moved datasets down as they require a lot of vertical space and I don't think they are that important compared to others

@NoraLoose
Copy link
Member

@IamShubhamGupto I like that better, thanks! I will shorten some of the names in #55, and let you know when it's updated.

@NoraLoose
Copy link
Member

I will merge this PR for now, so it is easier for us to look at the result. (I don't have the local build set up right now.) Let's then make suggestions in a follow-up PR. @johannag126 could maybe help, too, if she has time.

@NoraLoose NoraLoose self-requested a review September 5, 2023 14:19
@NoraLoose NoraLoose merged commit ee897e4 into m2lines:master Sep 5, 2023
@NoraLoose
Copy link
Member

Oops, hadn't realized that you haven't pushed the latest changes (the ones introducing the devisions). Sorry about that.

@NoraLoose
Copy link
Member

@IamShubhamGupto List updated (just shortened GCM-Filters and some items in the atmospheric parameterization section).

@IamShubhamGupto
Copy link
Member Author

@IamShubhamGupto List updated (just shortened GCM-Filters and some items in the atmospheric parameterization section).

no problem, the new design and updated titles will be in the next pr, shouldn't take long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants