-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need (editable) display name for Target #1251
Comments
Patch method added to |
@boriskovar-m2ms, @matej-vavrek: have you tried the new endpoint? |
Terrific - now we just need a frontend mechanism to edit it. I suggest an item on the hamburger menu, call it like "Edit target info". Pop up a modal with "Target display name". (In future, we'll use the modal for additional metadata.) @mwinokan please critique/confirm. |
Any update on this? May I implement it the way @phraenquex described in previous comment? |
@boriskovar-m2ms go ahead according to my spec |
In scope are also changes that whenever the name of the target is displayed to the user it should consistently display field |
@boriskovar-m2ms talked me through the changes - state does not reload on Target name change and the state is repainted in a way that leads to irregular behaviour. Estimate > 1 week of work to fix. Alternative, is to edit the target name via the Target Name list. This will solve state challenge and be a few hours of work. |
Main culprit for this erratic behavior is how are we handling NGL view. The problem is that NGL view is not reacting to our state but we are imperatively controlling the NGL view so when our state change requires remounting of NGL view component it will be not redrawn correctly. This is something that #1483 also addressing. |
* Squashed commit of the following: commit e613216 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load --------- Co-authored-by: matej <matej.vavrek@m2ms.sk>
* Squashed commit of the following: commit e613216 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load * #1322 added longcode column * updated general function for tag comparison --------- Co-authored-by: matej <matej.vavrek@m2ms.sk>
* Squashed commit of the following: commit e613216 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load * #1322 added longcode column * updated general function for tag comparison * #1505 adjusted getting of centroid_res --------- Co-authored-by: matej <matej.vavrek@m2ms.sk>
* Squashed commit of the following: commit e613216 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load * #1322 added longcode column * updated general function for tag comparison * #1505 adjusted getting of centroid_res * #1458 allow to tag XCA sites, temp commit # Conflicts: # js/components/preview/molecule/observationsDialog.js * #1458 adjusted functionality and styling to proper change tag --------- Co-authored-by: matej <matej.vavrek@m2ms.sk>
* Squashed commit of the following: commit e613216 Author: Boris Kovar <boris.kovar@m2ms.sk> Date: Wed Jul 31 13:57:02 2024 +0200 - implemented #1251 * #1482 added TagName and CentroidRes columns for expanded view of observation dialog * #1489 show warning toast message if is defined on target load * #1322 added longcode column * updated general function for tag comparison * #1505 adjusted getting of centroid_res * #1458 allow to tag XCA sites, temp commit # Conflicts: # js/components/preview/molecule/observationsDialog.js * #1458 adjusted functionality and styling to proper change tag * #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height --------- Co-authored-by: Boris Kovar <boris.kovar@m2ms.sk>
Display name (in landing page) needs to be changeable, after the first upload.
So needs "display_name" alongside "name". Small change to model, says Tim.
Needs a Modal for editing the name. Any authorised user.
(Might duplicate another ticket... @phraenquex to find.)
The text was updated successfully, but these errors were encountered: