Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need (editable) display name for Target #1251

Open
phraenquex opened this issue Dec 19, 2023 · 9 comments
Open

Need (editable) display name for Target #1251

phraenquex opened this issue Dec 19, 2023 · 9 comments
Assignees
Labels

Comments

@phraenquex
Copy link
Collaborator

Display name (in landing page) needs to be changeable, after the first upload.

So needs "display_name" alongside "name". Small change to model, says Tim.

Needs a Modal for editing the name. Any authorised user.

(Might duplicate another ticket... @phraenquex to find.)

@kaliif
Copy link
Collaborator

kaliif commented Jan 12, 2024

Patch method added to api/targets, Allows editing target object's display_name attribute (only that, nothing more). In staging as of 2.0.36

@mwinokan mwinokan added 2024-03-15 indigo Data dissemination loose ends and removed 2023-11-02 yellow Too big for V2 labels Mar 13, 2024
@mwinokan mwinokan moved this to ASAP critical in Fragalysis May 29, 2024
@phraenquex phraenquex added 2024-06-14 mint Data dissemination 2 and removed 2024-03-15 indigo Data dissemination loose ends labels Jun 14, 2024
@mwinokan
Copy link
Collaborator

@boriskovar-m2ms, @matej-vavrek: have you tried the new endpoint?

@matej-vavrek
Copy link
Collaborator

I have tried it. It seems working as api/targets/{targetId}/
image

@phraenquex
Copy link
Collaborator Author

Terrific - now we just need a frontend mechanism to edit it. I suggest an item on the hamburger menu, call it like "Edit target info".

Pop up a modal with "Target display name".

(In future, we'll use the modal for additional metadata.)

@mwinokan please critique/confirm.

@boriskovar-m2ms
Copy link
Collaborator

Any update on this? May I implement it the way @phraenquex described in previous comment?

@phraenquex
Copy link
Collaborator Author

@boriskovar-m2ms go ahead according to my spec

@boriskovar-m2ms
Copy link
Collaborator

In scope are also changes that whenever the name of the target is displayed to the user it should consistently display field display_name and not title. Currently we are only using title field in the code.

@boriskovar-m2ms boriskovar-m2ms moved this from ASAP critical to In Progress (DEV) in Fragalysis Jul 26, 2024
@Waztom
Copy link
Collaborator

Waztom commented Jul 30, 2024

@boriskovar-m2ms talked me through the changes - state does not reload on Target name change and the state is repainted in a way that leads to irregular behaviour. Estimate > 1 week of work to fix. Alternative, is to edit the target name via the Target Name list. This will solve state challenge and be a few hours of work.

boriskovar-m2ms added a commit that referenced this issue Jul 31, 2024
boriskovar-m2ms added a commit that referenced this issue Jul 31, 2024
commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251
@boriskovar-m2ms
Copy link
Collaborator

Main culprit for this erratic behavior is how are we handling NGL view. The problem is that NGL view is not reacting to our state but we are imperatively controlling the NGL view so when our state change requires remounting of NGL view component it will be not redrawn correctly. This is something that #1483 also addressing.

@boriskovar-m2ms boriskovar-m2ms moved this from In Progress (DEV) to In staging - assess function vs spec in Fragalysis Jul 31, 2024
@Waztom Waztom removed the 2024-06-14 mint Data dissemination 2 label Aug 1, 2024
@Waztom Waztom added the 2024-03-13 green Data dissemination label Aug 1, 2024
@mwinokan mwinokan moved this from In staging - assess function vs spec to Approved in staging - push to production in Fragalysis Sep 2, 2024
boriskovar-m2ms added a commit that referenced this issue Sep 5, 2024
commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251
boriskovar-m2ms added a commit that referenced this issue Sep 5, 2024
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

---------

Co-authored-by: matej <matej.vavrek@m2ms.sk>
boriskovar-m2ms added a commit that referenced this issue Sep 5, 2024
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

---------

Co-authored-by: matej <matej.vavrek@m2ms.sk>
matej-vavrek added a commit that referenced this issue Sep 12, 2024
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

---------

Co-authored-by: matej <matej.vavrek@m2ms.sk>
matej-vavrek added a commit that referenced this issue Sep 12, 2024
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

* #1505 adjusted getting of centroid_res

---------

Co-authored-by: matej <matej.vavrek@m2ms.sk>
matej-vavrek added a commit that referenced this issue Sep 12, 2024
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

* #1505 adjusted getting of centroid_res

* #1458 allow to tag XCA sites, temp commit

# Conflicts:
#	js/components/preview/molecule/observationsDialog.js

* #1458 adjusted functionality and styling to proper change tag

---------

Co-authored-by: matej <matej.vavrek@m2ms.sk>
matej-vavrek added a commit that referenced this issue Sep 13, 2024
* Squashed commit of the following:

commit e613216
Author: Boris Kovar <boris.kovar@m2ms.sk>
Date:   Wed Jul 31 13:57:02 2024 +0200

    - implemented #1251

* #1482 added TagName and CentroidRes columns for expanded view of observation dialog

* #1489 show warning toast message if is defined on target load

* #1322 added longcode column

* updated general function for tag comparison

* #1505 adjusted getting of centroid_res

* #1458 allow to tag XCA sites, temp commit

# Conflicts:
#	js/components/preview/molecule/observationsDialog.js

* #1458 adjusted functionality and styling to proper change tag

* #1508 removed TagName column in expanded observation dialog, changed order of columns, adjusted labels and tooltips, show observation dialog in its full height

---------

Co-authored-by: Boris Kovar <boris.kovar@m2ms.sk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In production (Done)
Development

No branches or pull requests

6 participants