Fix TaskOnKart.fix_random_seed_value cannnot handle None
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OptionalIntParameter introduced by spotify/luigi#3079 can solve this, but not yet released... |
Hi-king
commented
May 9, 2022
| @@ -52,7 +52,10 @@ class TaskOnKart(luigi.Task): | |||
| description='If this is false, this task is not treated as a part of dependent tasks for the unique id.', | |||
| significant=False) | |||
| fix_random_seed_methods = luigi.ListParameter(default=['random.seed', 'numpy.random.seed'], description='Fix random seed method list.', significant=False) | |||
| fix_random_seed_value = luigi.IntParameter(default=None, description='Fix random seed method value.', significant=False) | |||
| FIX_RANDOM_SEED_VALUE_NONE_MAGIC_NUMBER = -42497368 | |||
hirosassa
approved these changes
May 10, 2022
mski-iksm
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #286
Problem
Cannot set None for luigi.IntParameter. But
TaskOnKart.fix_random_seed_valuedoes this.So following code fails
Solution