PE: Support multiple debug directories and VCFeature, Repro, ExDllCharacteristics, POGO parsers #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4b
requested changes
Apr 21, 2024
|
@kkent030315 thanks for this PR, I think if we fix the basic nits this is ready to go, thank you! |
|
I'd also like to see this one go in for sure :) |
|
@m4b Thank you for the review! I'm going to mess with this PR very soon. |
- Added decent docs for `pe::debug` structs and constants - Added integration tests for `pe::debug::DebugData`
kkent030315
changed the title
|
@m4b Hi, this PR has been refactored, please take a look #403 (comment) for up-to-date changelists. |
kkent030315
commented
Oct 28, 2024
kkent030315
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #314.
- The change is straightforward. It makes theDebugData::image_debug_directory: ImageDebugDirectoryintoVec<ImageDebugDirectory>as someone pointed out in the #314 (comment). So this is to be an breaking change.- There is another addition of VC feature metadataIMAGE_DEBUG_TYPE_VC_FEATURE(IMAGE_DEBUG_VC_FEATURE_ENTRY) in the debug directory.If anyone have suggestion of making this semantics without breaking the backward compatibility I am open to discuss.
update:
DebugDataand its parsers for comfortable code that makes multiple debug directories in mind.TE::fixup_debug_datahas been merged toDebugData::parse_*: AsDebugDatais now more compatible with TE (Terse Executable) by addingDebugData::parse_with_opts_and_fixupand fixup RVA field inDebugDataandImageDebugDirectoryIteratorin order if any fixup is required forImageDebugDirectory::address_of_raw_dataandImageDebugDirectory::pointer_to_raw_data.pe::debug.IMAGE_DEBUG_TYPE_VC_FEATURE.IMAGE_DEBUG_TYPE_REPRO.IMAGE_DEBUG_TYPE_EX_DLLCHARACTERISTICS.IMAGE_DEBUG_TYPE_POGO.DebugDataparsers.impl ImageDebugDirectoryand it has been merged toDebugData::parse_*.