Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelists:
ImageTlsDirectory::parse*
andTlsData::parse*
, instead added new argumentis_64
as proposed in the issue.TlsData::raw_data
parser to compliant with panic-free design in goblin.I personally prefer not making
ImageTlsDirectory32
―as it's more comfortable than the way duplicating the same kind of structs and merging to 64-bit as proposed in the issue.This change should be marked as breaking-change and I expect this to be rolled up in 0.10.