Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying in miniz makes this difficult to use with projects that already use miniz #92

Open
johnboiles opened this issue Apr 19, 2024 · 1 comment

Comments

@johnboiles
Copy link

miniz is vendor'd into this repo, causing duplicate symbol linker errors if M5GFX is used in projects that already use miniz.

Not sure on the best way to handle this. Here are some options:

  • Compile time flag that skips compiling miniz.c (assumes symbols will come from somewhere else)
  • Rename symbols in miniz.c so they don't conflict with other projects using miniz

I'm running into this specifically in an esp-idf project where I have a miniz component already.

lovyan03 added a commit that referenced this issue May 19, 2024
@lovyan03
Copy link
Collaborator

Hello, @johnboiles
I've updated the develop branch.
I've changed the names of symbols in the miniz, so I hope they won't conflict with miniz from other projects.
If there are no problems, this will be reflected in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants