Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): biometric api implementation #214

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

maggialejandro
Copy link
Contributor

Description

Implement new Biometric API on Android

On devices running Android 10 (API 29) and above, this will query the framework's version of BiometricManager. On Android 9.0 (API 28) and prior versions, this will query FingerprintManagerCompat.

biometricStack (1)

Related
#159

Type of change

If showModal is true it now uses a BiometricPrompt to authenticate the user.
If showModal is false, it uses the FingerprintManager

Test case

  1. Installed an apk with old native version
  2. Call setItem with showModal=false
  3. Upgraded apk using new code
  4. Call getItem returns the previously saved value

@mCodex
Copy link
Owner

mCodex commented Jul 24, 2020

Awesome work! 😄 Thanks!!

I'm currently working on a new example project (in feature/example) for RNSInfo and I'll use it there.

PR number: 💯

@lustig-bakkt
Copy link

Unrelated question: @maggialejandro How did you create this beautiful and concise diagram?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants